-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements Bar Styling Bug Fix #498
Conversation
* Migrate to vue3 * Fix courses not showing up due to incorrect usage of draggable library * Fix router issue due to incorrect usage of routing library * Fix bottombar information loading due to vue3 reactivitity changes Need to update only when all fields are ready, since vue3 cannot detect nested field changes now. * Fix semester height issue by passing style via componentData another breaking change of vue-draggable library * Correct fix for missing value prop for ResetConfirmation modal vue3 changes value in v-model to be modelValue. * Fix reset confirmation modal * Unbreak scrollIntoView * Unbreak scrollIntoView * Fix graduation year autoscroll
* Add human-development minor * Add human dev major * CI check * PR fixes - including FL common checker * Add TODO comment
* Add linguistics major * Update tests * Add linguistics minor, update urls * Add minimum credit checker * Allow ling minors to take foundation courses as electives (double counting issue) * Add todos, fix tests * Update decorated-requirements.json * PR description, warning, and TODO updates
* Add and display slot names to every requirement * fix typo
…dropdowns) (#459) * Fix edit semester dropdowns resetting * Bug fix on total credit denominator increasing * Remove special AG case * Update 120 credit descriptions
* Add catalogAttribute to fetcher * Add CU-UGR checker to linguistics * Update decorated-requirements.json
* Start of MSE - need to finish applications and test * Fix categorychecker and test * Add PAM major, some HE/HD fixes * PR fixes
As discussed before subrequirement means two different things, depending on whether you are working on the algorithm or in the UI. This diff makes things more consistent. Since we finally have a consistent names for requirement stuff, I added them to the docs to reduce future confusion.
* Add entrance year to onboarding * Quick scroll change * Scroll new semester year dropdown to entrance year * nit
* Add phys major * Address phys nuances * Add ep major * Fix test, lint * Update phys requirements * Shorten description, update comments * Update concentration outside physics checker
* start sts major * add sts major * update descriptions on sts major * rename slot * update requirements
* added astro req * run tests * updated descriptions on astro major
* Add more possible foreign langs * Run req gen * Comment out course codes that don't count for A&S FL
* Onboarding Required Fields for first page and handling invalid majors/minors * make isError and isInvalidMajorOrMinorError computed props
* Set class ratings to null for courses not in CUReviews * Fix styling issue when courses have no description * Switch tabs to buttons * Add hover state to tabs
Updates our course search to use [fuse.js](fusejs.io)
* added spanish minor and major * finalised spanish reqs * updated spanish major to use subreqs * finalised food science major * ran npm req gen * change to spanish minor * ran formatter * linter fix * fixed electives bug for spanish major * Change slot name from 'courses' to 'course' * shortened course slot names * added requested changes * improved food sci concentration description
Added biology & society and ESS majors Co-authored-by: einc <ein.chang@gmail.com>
Added ece, robotics, hp minors
[diff-counting] Significant lines: 6345. This diff might be too big! Developer leads are invited to review the code. |
Visit the preview URL for this PR (updated for commit f2d7f1c): https://cornelldti-courseplan-dev--pr498-master-az2fowxl.web.app (expires Thu, 13 May 2021 19:52:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the test plan and LGTM! I think the reason why you're seeing the commits from the previous push to prod is because I accidentally did "Squash and Merge" instead of "Merge Pull Request".
The base branch was changed.
oh shoot, before i saw theresa's comments i changed bases to check if it'd get rid of the other commits (it did not) 😅 can you guys confirm again? @SamChou19815 @tcho6319 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test plan works and everything LGTM!
Summary
This PR fixes the frontend bug where the requirement bar's styling was altered by an update on an imported stylesheet.
![image](https://user-images.githubusercontent.com/55263191/117357145-91cc5100-ae82-11eb-8e81-be055fe1be0b.png)
Test Plan
Review frontend and make sure everything looks normal
Review basic functionality (add/delete some courses/semesters)
Notes
This includes commits that have already been pushed to prod which is a little suspicious. Is this normal?