-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse GPT Output #863
base: parse-prereqs
Are you sure you want to change the base?
Parse GPT Output #863
Conversation
[diff-counting] Significant lines: 217. |
Visit the preview URL for this PR (updated for commit 67b5b0f): https://cornelldti-courseplan-dev--pr863-andrew-parse-ekj5mqx6.web.app (expires Mon, 04 Dec 2023 18:43:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Can you delete the commented code and add tests?
This seems like a very useful step into deploying a more rigorous requirement checking system! |
21332c0
to
75acb6a
Compare
2614a94
to
9664d37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Summary
Parses the GPT Output into a usable dictionary to represent the boolean expression of prerequisites.
Remaining TODOs:
Test Plan
Will add under python as new unit tests