Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse GPT Output #863

Open
wants to merge 4 commits into
base: parse-prereqs
Choose a base branch
from
Open

Parse GPT Output #863

wants to merge 4 commits into from

Conversation

andxu282
Copy link
Collaborator

@andxu282 andxu282 commented Oct 20, 2023

Summary

Parses the GPT Output into a usable dictionary to represent the boolean expression of prerequisites.

  • implemented parser for parsing GPT output into dict

Remaining TODOs:

  • add test cases
  • make type change based on OR or AND clause

Test Plan

Will add under python as new unit tests

@andxu282 andxu282 requested a review from a team as a code owner October 20, 2023 00:31
@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 20, 2023

[diff-counting] Significant lines: 217.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Visit the preview URL for this PR (updated for commit 67b5b0f):

https://cornelldti-courseplan-dev--pr863-andrew-parse-ekj5mqx6.web.app

(expires Mon, 04 Dec 2023 18:43:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can you delete the commented code and add tests?

@PabloRaigoza
Copy link
Contributor

This seems like a very useful step into deploying a more rigorous requirement checking system!
I would only suggest in the test cases adding test cases where certain the the preconditions in your code may not be satisfied. For example 'and CHEM 2080'. Alternatively you can keep asking GPT for responses until preconditions are met.

python/test_prereq_parse.py Show resolved Hide resolved
python/test_prereq_parse.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants