Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Requirement Ranking for Frontend #876

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PabloRaigoza
Copy link
Contributor

Summary

This PR is the last in the series to implement course recommendations based on course popularity #866 computed and stored the data in firebase, giving course rankings of a given requirement's slot. #873 implemented frontend changes for displaying the course recommendations. This PR takes the the data computed and stored from firebase, stores it into the Vuex store, and gives the information to the frontend so the frontend can display course popularities. It should be noted that #873 should be backwards compatible and so this PR can be merged before or after #867.

  • Populate Vuex store with requirement course rankings
  • Passed information to frontend to display recommended courses

Test Plan

  • CS 2112 was display before CS 2110, however CS 2110 is more popular and now it is displayed before CS 2112.

@PabloRaigoza PabloRaigoza requested a review from a team as a code owner December 4, 2023 01:33
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 112.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Visit the preview URL for this PR (updated for commit 938f6bd):

https://cornelldti-courseplan-dev--pr876-pablo-load-fulfillme-gucxujaa.web.app

(expires Wed, 03 Jan 2024 01:35:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just store the recommendations for a requirement already properly ranked in the Firestore so we don't have to do that computation on the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants