Migrate from create-react-app-typescript to official CRA #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glitched
changed the title
Glitched
changed the title
SamChou19815
approved these changes
Dec 9, 2019
| @@ -15,7 +15,7 @@ import ProfessorPeopleView from './pages/ProfessorPeopleView'; | |||
| import { Analytics } from './includes/Analytics'; | |||
| import { Loader } from 'semantic-ui-react'; | |||
| import { userUpload } from '../firebasefunctions'; | |||
| import { useMyCourseUser } from 'src/firehooks'; | |||
| import { useMyCourseUser } from '../firehooks'; | |||
There was a problem hiding this comment.
Latest CRA can actually support it. You can set the baseUrl in tsconfig. Not push blocking.
Comment on lines
13
to
+14
| export class Analytics extends React.Component { | ||
| props: AnalyticsProps; | ||
| props!: AnalyticsProps; |
There was a problem hiding this comment.
Probably
export class Analytics extends React.Component<AnalyticsProps> {}There was a problem hiding this comment.
Makes sense. I just did this to get it to compile. If I have time, I'd love to make it a hooks component
SamChou19815
added a commit
that referenced
this pull request
Feb 1, 2020
* Refactor ProfOHInfo * Progress * More Progress * Remove unused packages * Remove unused imports * Fix comparisons * I wish moment had types * Fix broken TA dropdown * Migrate from create-react-app-typescript to official CRA (#191) * Migrate to create-react-app * Fix crashes * var -> let * Check in safe API key This key is designed to be public Co-authored-by: Ryan Slama <Glitched@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace create-react-app-typescript with the official create-react-app. Create-react-app-typescript is deprecated and no longer receiving updates in favor of official typescript support.
Inside This PR
Notes
Moving away is essential for the long term health of the project and I figured I would do it was I was here because I've spent more time fighting with Typescript than most and some of the changes were non-obvious.
I fixed all the breaking errors, but this created a bunch of warnings (where we were doing bad stuff). We should probably get around to fixing all of them at some point, but I think an incremental adoption strategy would work best.
Future work involves moving from the deprecated TSLint to ESLint. Then we should improve our linting for accessibility, code format, and code safety.
Breaking Changes
/src/components/types/Checklist: