Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rms/prof oh view #199

Merged
merged 11 commits into from
Feb 1, 2020
Merged

Rms/prof oh view #199

merged 11 commits into from
Feb 1, 2020

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented Feb 1, 2020

Inside This PR

Ryan's branch of dev-firebase. Not sure what happened in this branch at the moment, but it looks like it's doing some good stuff.

It appears that the majority of the the code is for migration from react-scripts-ts to react-scripts

Notes

Breaking Changes

  • Database schema change (anything that changes Postgres)
  • I updated existing types in /src/components/types/
  • Other change that could cause problems (Detailed in notes)

Checklist:

  • My code follows the code style of this project.
  • My changes requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore
  • I tested affected functionality
  • I resolved any merge conflicts
  • My PR is ready for review

@SamChou19815 SamChou19815 marked this pull request as ready for review February 1, 2020 21:53
@SamChou19815 SamChou19815 merged commit 9a52b29 into develop-firebase Feb 1, 2020
@SamChou19815 SamChou19815 deleted the rms/prof-oh-view branch February 1, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants