Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] CI/CD testing on local servers #424

Merged
merged 38 commits into from
Nov 21, 2021
Merged

[CI] CI/CD testing on local servers #424

merged 38 commits into from
Nov 21, 2021

Conversation

hecmay
Copy link
Collaborator

@hecmay hecmay commented Sep 30, 2021

For adding new features

Add feature: add CD/CI testing on our local server. Right now, some test cases requiring EDA tools are skipped in CD/CI testing on CircleCI servers. This PR will add CI/CD testing on our local server, which enables us to verify our design with EDA tools like Vivado HLS or AOC.

How to use the new feature: The local CI/CD testing process is completely automatic.

Detailed description:. For each commit, the webhook on github will automatically inform the local CI/CD runner installed on our local server to pull back the latest changes and run the test cases. The test result will be sent back to github repo and be displayed as the status (i.e., passed or failed) of the commit.

Link to the tests: test_runtime_build.py

Copy link
Collaborator

@seanlatias seanlatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test csim for all Xilinx backend. At least for code generation. But we can add those incrementally. I would suggest you create a separate test case just for testing the CI flow. We'll create a separate PR for modifying the test flow of existing tests.

.github/workflows/zhang-21.yml Outdated Show resolved Hide resolved
.github/workflows/zhang-21.yml Outdated Show resolved Hide resolved
.github/workflows/zhang-21.yml Outdated Show resolved Hide resolved
.github/workflows/zhang-21.yml Outdated Show resolved Hide resolved
tests/test_runtime_build.py Outdated Show resolved Hide resolved
@hecmay
Copy link
Collaborator Author

hecmay commented Nov 18, 2021

@seanlatias Finally fixed. It turned out the previous seg fault error was caused by a small error in host code generation (i.e., q.finished was missed at the very end).

I believe it is ready for review.

@seanlatias
Copy link
Collaborator

Can we just revert tests/test_runtime_build.py? Or is there any reason we need to change this file? Otherwise this PR LGTM.

@seanlatias seanlatias added the CI label Nov 21, 2021
@seanlatias seanlatias changed the title [TEST] CI/CD testing on local servers [CI] CI/CD testing on local servers Nov 21, 2021
@seanlatias seanlatias merged commit 2010ba2 into master Nov 21, 2021
@hecmay hecmay deleted the continuous-intg branch November 21, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants