-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fantasizing is very slow on GPU due to torch.qr #1157
Comments
Yeah that makes sense. Also, looking through the code above that section, we know that the |
Fixes (temporarily) #1157, until pytorch/pytorch#22573 is addressed
Fixed for now by #1224 |
🐛 Bug
torch.qr is causing things to be very slow on the GPU, when using fantasies. This is likely caused by pytorch/pytorch#22573.
To reproduce
See the following notebook example.
KG_GPU_investigate.ipynb.txt
** Stack trace/error message **
![CPU](https://user-images.githubusercontent.com/18407088/82617537-388de380-9b85-11ea-91c7-c5d86fe103b7.png)
![GPU](https://user-images.githubusercontent.com/18407088/82617539-3b88d400-9b85-11ea-9ecc-c5171d8380b7.png)
See the following profile results.
kg_cpu.cprofile.txt
kg_gpu.cprofile.txt
Expected Behavior
Running on CUDA should show speedups compared to CPU.
System information
Please complete the following information:
The text was updated successfully, but these errors were encountered: