Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform QR composition in exact prediction strategy on the CPU #1224

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Perform QR composition in exact prediction strategy on the CPU #1224

merged 2 commits into from
Jul 24, 2020

Conversation

Balandat
Copy link
Collaborator

Fixes (temporarily) #1157, until pytorch/pytorch#22573 is addressed

@Balandat Balandat mentioned this pull request Jul 23, 2020
Closed
@Balandat
Copy link
Collaborator Author

Balandat commented Jul 23, 2020 •
edited

Benchmark for CPU vs GPU in terms of size (on a V100):

qr_bench
qr_bench_batched

Adding a size check at n=2048 based on this.

@jacobrgardner jacobrgardner merged commit 0a1e0d6 into master Jul 24, 2020
@jacobrgardner jacobrgardner deleted the fix_cuda_qr branch July 24, 2020 00:36
@jacobrgardner jacobrgardner mentioned this pull request Jul 24, 2020
Closed
@Parskatt Parskatt mentioned this pull request Oct 20, 2020
Closed
@naefjo naefjo mentioned this pull request Jan 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobrgardner jacobrgardner jacobrgardner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Balandat @jacobrgardner