Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute standard distance matrices directly instead of using sqrt(). #455

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Compute standard distance matrices directly instead of using sqrt(). #455

merged 2 commits into from
Jan 3, 2019

Conversation

jacobrgardner
Copy link
Member

Fixes an issue where certain kernel backward passes (e.g. Matern) would be less stable because we compute the squared distance matrix and then use sqrt. This PR uses torch.norm to compute the non squared distances directly.

@jacobrgardner jacobrgardner force-pushed the kernel_stability branch 2 times, most recently from 628afb5 to 057228f Compare January 2, 2019 23:06
Balandat
Balandat approved these changes Jan 3, 2019
View reviewed changes
Copy link
Collaborator

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, would you mind retaining the docstring (with the appropriate changes) before merging this in though?

@jacobrgardner jacobrgardner merged commit c9db6e8 into master Jan 3, 2019
@jacobrgardner jacobrgardner deleted the kernel_stability branch January 3, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balandat Balandat Balandat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobrgardner @Balandat