Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow .to() to operate on tensors #45

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Allow .to() to operate on tensors #45

merged 3 commits into from
Jan 3, 2023

Conversation

Balandat
Copy link
Collaborator

@Balandat Balandat commented Jan 2, 2023

Addresses #44.

@Balandat Balandat requested a review from gpleiss January 2, 2023 23:29
SebastianAment
SebastianAment approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@SebastianAment SebastianAment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left comments inline. Could be worth adding the non-cpu tensor test before merging.

linear_operator/utils/generic.py Outdated Show resolved Hide resolved
linear_operator/utils/generic.py Outdated Show resolved Hide resolved
test/utils/test_generic.py Show resolved Hide resolved
@Balandat Balandat merged commit 71c199a into cornellius-gp:main Jan 3, 2023
@Balandat Balandat deleted the tensor_to branch January 3, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianAment SebastianAment SebastianAment approved these changes

@gpleiss gpleiss Awaiting requested review from gpleiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Balandat @SebastianAment