Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blurry pixels bug for decoding of jpeg2000 #497

Closed
wants to merge 1 commit into from

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Dec 7, 2022

Switching j2k decoder to wasm had introduced a pixelated/blury bug for some images.

Reported here:

Data by community can be found here

Steps taken discussed here

CC @swederik @heyflynn @kunjesh1 @lambacini , try here https://deploy-preview-497--cornerstone-wado-image-loader.netlify.app/dicomfile/index.html

Also Chris @chafey just fixed the decode problem here which I will use in codecs

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for cornerstone-wado-image-loader ready!

Name Link
🔨 Latest commit cf3c120
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/638ff43e7362110008c8b8de
😎 Deploy Preview https://deploy-preview-497--cornerstone-wado-image-loader.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi requested a review from swederik December 7, 2022 02:02
@lambacini
Copy link

CR Image
image
CT Image
ct_test

i tested it with previous test images.
everything seems fine, thanks.

@kunjesh1
Copy link

kunjesh1 commented Dec 9, 2022

Thanks @sedghi , its working now :)
Screenshot 2022-12-09 at 11 52 30 AM

@daniel-encord
Copy link

daniel-encord commented Jan 13, 2023

Hey @swederik and @sedghi, is there an estimated time on when this fix will go in? Thanks

@sedghi
Copy link
Member Author

sedghi commented Jan 13, 2023

@daniel-encord We have updated the codecs that should solve it at codecs level. I don't want to merge this PR, but update codecs versions. I need time to do some final tests

@daniel-encord
Copy link

Thanks for the swift response @sedghi ! 🙏 will keep an eye out for the fix 🙌

@sedghi
Copy link
Member Author

sedghi commented May 2, 2023

Fixed

@sedghi sedghi closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants