Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Using the new http errors introduced in #213 #220

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Using the new http errors introduced in #213 #220

merged 1 commit into from
Jun 6, 2020

Conversation

kolyaopahle
Copy link
Contributor

@kolyaopahle kolyaopahle commented Jun 6, 2020 •
edited
Loading

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)

Description

This PR switches the exception handling in the submission flow to use the new network errors introduced by #213

@kolyaopahle kolyaopahle requested review from jakobmoellerdev and a team June 6, 2020 10:05
@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers labels Jun 6, 2020
@kolyaopahle kolyaopahle changed the base branch from dev to feature/complex-http-errors June 6, 2020 10:06
@jakobmoellerdev jakobmoellerdev merged commit 61ef3a9 into feature/complex-http-errors Jun 6, 2020
@jakobmoellerdev jakobmoellerdev deleted the fix/use-new-http-errors branch June 6, 2020 15:29
jakobmoellerdev pushed a commit that referenced this pull request Jun 6, 2020
@kolyaopahle
Complex HTTP Errors (#213)
16f016a 
* Complex HTTP Errors

Signed-off-by: d067928 <jakob.moeller@sap.com>

* Correct Boolean Logic for Client/Server Error Check

Signed-off-by: d067928 <jakob.moeller@sap.com>

* Moved error handling of submission flow to CwaWebExceptions (#220)

Co-authored-by: Kolya Opahle <k.opahle@sap.com>
@jakobmoellerdev jakobmoellerdev linked an issue Jun 7, 2020 that may be closed by this pull request
Replace Try/Catch with CoroutineExceptionHandler for Exposure Notification Exceptions. #12
Closed
@jakobmoellerdev jakobmoellerdev removed a link to an issue Jun 7, 2020
Replace Try/Catch with CoroutineExceptionHandler for Exposure Notification Exceptions. #12
Closed
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

Assignees
No one assigned
Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolyaopahle @jakobmoellerdev