Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Checkins Repository (EXPOSUREAPP-5421) #2547

Merged
merged 17 commits into from
Mar 9, 2021
Merged

Checkins Repository (EXPOSUREAPP-5421) #2547

merged 17 commits into from
Mar 9, 2021

Conversation

chris-cwa
Copy link
Contributor

Added the repository for event check ins. Will add unit tests, if approach is ok.

@chris-cwa chris-cwa added the maintainers Tag pull requests created by maintainers label Mar 8, 2021
@chris-cwa chris-cwa added this to the 1.15.0 milestone Mar 8, 2021
@chris-cwa chris-cwa requested a review from a team March 8, 2021 11:06
@mtwalli mtwalli self-assigned this Mar 8, 2021
@harambasicluka harambasicluka modified the milestones: 1.15.0, 1.16.0 Mar 8, 2021
@LukasLechnerDev LukasLechnerDev mentioned this pull request Mar 8, 2021
Merged
1 task
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 8, 2021
mtwalli
mtwalli approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!, minor things maybe when you write the unit test , you can address them

.../main/java/de/rki/coronawarnapp/eventregistration/checkins/TraceLocationCheckInRepository.kt Outdated Show resolved Hide resolved
.../main/java/de/rki/coronawarnapp/eventregistration/checkins/TraceLocationCheckInRepository.kt Outdated Show resolved Hide resolved
.../main/java/de/rki/coronawarnapp/eventregistration/checkins/TraceLocationCheckInRepository.kt Outdated Show resolved Hide resolved
mtwalli
mtwalli approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

LukasLechnerDev
LukasLechnerDev approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chris-cwa chris-cwa merged commit 424d1ad into feature/5062-event-registration-main Mar 9, 2021
@chris-cwa chris-cwa deleted the feature/5421_checkins_repo branch March 9, 2021 16:32
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

@mtwalli mtwalli mtwalli approved these changes

Assignees

@LukasLechnerDev LukasLechnerDev

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chris-cwa @LukasLechnerDev @mtwalli @harambasicluka