This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Create events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484) #2549
Merged
mtwalli
merged 39 commits into
feature/5062-event-registration-main
from
feature/5470-Create-HostedEvents-repository
Mar 11, 2021
Merged
Create events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484) #2549
mtwalli
merged 39 commits into
feature/5062-event-registration-main
from
feature/5470-Create-HostedEvents-repository
Mar 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of suspend functions
…-Create-HostedEvents-repository # Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/eventregistration/ui/EventRegistrationTestFragment.kt # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/ui/main/MainActivityTestModule.kt # Corona-Warn-App/src/deviceForTesters/res/layout/fragment_test_eventregistration.xml # Corona-Warn-App/src/deviceForTesters/res/navigation/test_nav_graph.xml
LukasLechnerDev
changed the title
Feature/5470 Create hosted events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484)
Create hosted events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484)
Mar 8, 2021
LukasLechnerDev
changed the title
Create hosted events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484)
Create events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484)
Mar 8, 2021
mtwalli
reviewed
Mar 8, 2021
...App/src/main/java/de/rki/coronawarnapp/eventregistration/storage/entity/HostedEventEntity.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 8, 2021
...App/src/main/java/de/rki/coronawarnapp/eventregistration/storage/entity/HostedEventEntity.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 8, 2021
...-App/schemas/de.rki.coronawarnapp.eventregistration.storage.EventRegistrationDatabase/1.json
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 8, 2021
.../java/de/rki/coronawarnapp/test/eventregistration/ui/createevent/CreateEventTestViewModel.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 8, 2021
...ain/java/de/rki/coronawarnapp/eventregistration/storage/repo/DefaultHostedEventRepository.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 8, 2021
...ain/java/de/rki/coronawarnapp/eventregistration/storage/repo/DefaultHostedEventRepository.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 8, 2021
...ain/java/de/rki/coronawarnapp/eventregistration/storage/repo/DefaultHostedEventRepository.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 8, 2021
...c/main/java/de/rki/coronawarnapp/eventregistration/storage/EventRegistrationStorageModule.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 9, 2021
...-App/schemas/de.rki.coronawarnapp.eventregistration.storage.EventRegistrationDatabase/1.json
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 9, 2021
...-App/schemas/de.rki.coronawarnapp.eventregistration.storage.EventRegistrationDatabase/1.json
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 9, 2021
...Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/DefaultTraceLocation.kt
Show resolved
Hide resolved
d4rken
reviewed
Mar 9, 2021
...Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/DefaultTraceLocation.kt
Show resolved
Hide resolved
...in/java/de/rki/coronawarnapp/eventregistration/storage/entity/EventRegistrationConverters.kt
Outdated
Show resolved
Hide resolved
...p/src/main/java/de/rki/coronawarnapp/eventregistration/storage/entity/TraceLocationEntity.kt
Show resolved
Hide resolved
…eLocationRepository.kt
…-Create-HostedEvents-repository # Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/DataReset.kt
…ntRegistration' database
…-Create-HostedEvents-repository # Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/EventRegistrationModule.kt
mtwalli
reviewed
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small things in tests , otherwise looks good!
...droidTest/java/de/rki/coronawarnapp/eventregistration/storage/TraceLocationCheckInDaoTest.kt
Outdated
Show resolved
Hide resolved
.../src/androidTest/java/de/rki/coronawarnapp/eventregistration/storage/TraceLocationDaoTest.kt
Outdated
Show resolved
Hide resolved
...st/java/de/rki/coronawarnapp/eventregistration/storage/entity/TraceLocationConvertersTest.kt
Outdated
Show resolved
Hide resolved
...pp/src/test/java/de/rki/coronawarnapp/eventregistration/events/DefaultTraceLocationKtTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/de/rki/coronawarnapp/eventregistration/storage/entity/TraceLocationEntityTest.kt
Outdated
Show resolved
Hide resolved
mtwalli
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
d4rken
suggested changes
Mar 11, 2021
...c/main/java/de/rki/coronawarnapp/eventregistration/storage/entity/TraceLocationConverters.kt
Outdated
Show resolved
Hide resolved
d4rken
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a first version of the Event Repository and also simple screens to create new events and see all stored events.
After an event is created, we need to send it to the backend whitch then returns a signature. The response protobuf is mocked in this PR. It is still using the outdated protobuf objects (Event and SignedEvent instead of TracingLocation and SignedTracingLocation), but I will update them as soon as we have them.
@chiljamgossow @d4rken @mtwalli We can discuss here whether it is better to store events and locations in different database tables. The techspec says, that we should store them in a single one and have an Type field.
TODO:
The Screens are accessible via our TestMenu: