Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Create events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484) #2549

Conversation

LukasLechnerDev
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev commented Mar 8, 2021

This PR adds a first version of the Event Repository and also simple screens to create new events and see all stored events.

After an event is created, we need to send it to the backend whitch then returns a signature. The response protobuf is mocked in this PR. It is still using the outdated protobuf objects (Event and SignedEvent instead of TracingLocation and SignedTracingLocation), but I will update them as soon as we have them.

@chiljamgossow @d4rken @mtwalli We can discuss here whether it is better to store events and locations in different database tables. The techspec says, that we should store them in a single one and have an Type field.

TODO:

The Screens are accessible via our TestMenu:

image

image

image

image

@LukasLechnerDev LukasLechnerDev requested a review from a team March 8, 2021 11:47
@LukasLechnerDev LukasLechnerDev changed the title Feature/5470 Create hosted events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484) Create hosted events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484) Mar 8, 2021
@LukasLechnerDev LukasLechnerDev changed the title Create hosted events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484) Create events repository (EXPOSUREAPP-5470) (EXPOSUREAPP-5482)(EXPOSUREAPP-5484) Mar 8, 2021
@mtwalli mtwalli self-assigned this Mar 8, 2021
@ralfgehrer ralfgehrer added this to the 1.16.0 milestone Mar 8, 2021
@ralfgehrer ralfgehrer added the maintainers Tag pull requests created by maintainers label Mar 8, 2021
@LukasLechnerDev LukasLechnerDev removed the author merge PR to be merged by author label Mar 11, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small things in tests , otherwise looks good!

Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

56.8% 56.8% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit daa6c77 into feature/5062-event-registration-main Mar 11, 2021
@mtwalli mtwalli deleted the feature/5470-Create-HostedEvents-repository branch March 11, 2021 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants