Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add a test for the scan status within SubmissionViewModel.kt #364

Conversation

tobiasdroste
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in strings.xml (see issue Text and Translation Contributions #72)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

This PR adds a test for the scan status of the SubmissionViewModel. It tests whether the scan status changes to the right status after starting and when the validateAndStoreTestGUID gets a valid or invalid guid passed.

@tobiasdroste tobiasdroste requested a review from a team June 10, 2020 20:53
@tobiasdroste
Copy link
Contributor Author

tobiasdroste commented Jun 10, 2020

The tests on CircleCI all passed. Sonar doesn't seem to work though:
ERROR: Error during SonarQube Scanner execution
ERROR: Parameter 'sonar.pullrequest.branch' is mandatory for a pull request analysis

@tobiasdroste
Copy link
Contributor Author

Is anything missing here so this can be merged?

Copy link
Member

@Fabian-K Fabian-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your @tobiasdroste for being patient and of course your contribution! LGTM

@Fabian-K Fabian-K merged commit 1e18604 into corona-warn-app:dev Jul 10, 2020
jakobmoellerdev pushed a commit that referenced this pull request Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants