This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix networkstate update behavior (DEV) #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Just force a refresh on any state change. Also see: https://issuetracker.google.com/issues/144891976
d4rken
added
bug
|
@d4rken its much better than before. |
This was also working for me before.
This should be fixed by this PR, on which devices does it happen, and how did you test it? |
Tested on Pixel 3xl. There might be no 100%reliable solution... |
chiljamgossow
approved these changes
Jul 28, 2021
|
Kudos, SonarCloud Quality Gate passed!聽 聽 |
BMItr
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network callback for onUnavailable() is not reliable.
Solution: Just force a refresh on any state change.
Also see:
https://issuetracker.google.com/issues/144891976
According to that ticket, it's fixed in a "future release", but on my Pixel 3a@Android11, it's not 馃し.
@BMItr noticed this during debugging.