Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Local statistics connectivity (EXPOSUREAPP-8436) #3815

Merged

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Jul 27, 2021

This PR addresses Exposureapp-8436.
[Android] Statistics behavior when offline during onboarding.

How to test:

  • visit statistic cards on the MainFragment
  • check that its prevented to add a new card without internet connection (by notification or addView hiding)
  • check if the addCard Element reappears after switching Internet/Wifi on
    (if there is no cached data or internet connection, statistic data should not be shown)

Note: MERGE AFTER #3767 (done)

Screenshots:

No Internet Case:

  • regular AddCard Item should not be visible (greyed out with explaining text)
    image

with internet:
image

@BMItr BMItr requested review from a team July 27, 2021 15:03
@BMItr BMItr marked this pull request as draft July 27, 2021 15:04
@BMItr BMItr added maintainers Tag pull requests created by maintainers author merge PR to be merged by author labels Jul 27, 2021
@harambasicluka harambasicluka added this to the 2.7.0 milestone Jul 27, 2021
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved.

@BMItr BMItr marked this pull request as ready for review July 28, 2021 12:18
marcauberer
marcauberer previously approved these changes Jul 28, 2021
@marcauberer marcauberer self-assigned this Jul 28, 2021
harambasicluka and others added 2 commits July 29, 2021 12:44
please take over the reviewed text for the error message on no internet connection
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take over UA text

@BMItr
Copy link
Contributor Author

BMItr commented Jul 29, 2021

please take over UA text

all right.
LayoutAdjustment needed for longer texts. in progress... (adjusted. Screenshot updated in the description)

@fynngodau
Copy link
Contributor

Two things are not entirely addressed by this PR so far:

  • When the internet connection is disabled while the selection is open, the user can still finish adding the card with the same behavior as in Bad behavior when adding local incidence without network access cwa-documentation#672.
    This could happen for example in a situation where the system thinks that the network is available, but requests are never answered and time out.
  • After toggling a network connection, the statistics cards jump to the default position (first card after the "add card card").

@BMItr
Copy link
Contributor Author

BMItr commented Jul 29, 2021

Two things are not entirely addressed by this PR so far:

  • When the internet connection is disabled while the selection is open, the user can still finish adding the card with the same behavior as in Bad behavior when adding local incidence without network access cwa-documentation#672.
    This could happen for example in a situation where the system thinks that the network is available, but requests are never answered and time out.
  • After toggling a network connection, the statistics cards jump to the default position (first card after the "add card card").

it could also be that an asteriod hits the user during adding a card. This case is also not handled.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

36.4% 36.4% Coverage
0.0% 0.0% Duplication

@vaubaehn
Copy link
Contributor

I didn't have problems with asteroids so far, but

This could happen for example in a situation where the system thinks that the network is available, but requests are never answered and time out.

is a situation that I'm often experiencing. And probably not me alone.
Sure, not everything needs to be pressed into one PR, but at least it's worth to think about.

Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@harambasicluka harambasicluka merged commit 0650ae3 into release/2.7.x Jul 30, 2021
@harambasicluka harambasicluka deleted the feature/8436-local-statistics-connectivity branch July 30, 2021 07:43
@BMItr
Copy link
Contributor Author

BMItr commented Jul 30, 2021

I didn't have problems with asteroids so far, but

This could happen for example in a situation where the system thinks that the network is available, but requests are never answered and time out.

is a situation that I'm often experiencing. And probably not me alone.
Sure, not everything needs to be pressed into one PR, but at least it's worth to think about.

@vaubaehn @fynngodau
Yes. You are right on this.
Follow Up PR will come (I already prepared something about the jumping card issue, and maybe I have somehting for the in-between-no-internet-case).
For now I cannot pack more cases in this ticket (as requested) regarding other tickets...
Greetz 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author merge PR to be merged by author maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants