Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Warn info screen (EXPOSUREAPP-8947) #3917

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Warn info screen (EXPOSUREAPP-8947) #3917

merged 5 commits into from
Aug 13, 2021

Conversation

AlexanderAlferov
Copy link
Contributor

Warn guests info screen.

Screenshot 2021-08-12 at 17 57 31 Screenshot 2021-08-12 at 17 57 07

How to test:

  1. Home Screen -> "Planning an event?" card
  2. Three point menu -> "In Vertretung warnen"
  3. ✨ Tadaaa ✨

@AlexanderAlferov
Strings
f4af839
@AlexanderAlferov
Fragment
84f31b5
@AlexanderAlferov
Merge remote-tracking branch 'origin/feature/8898-event-organizer-war…
2747b63 
…ning' into feature/8947-warn-info-screen

# Conflicts:
#	Corona-Warn-App/src/main/res/navigation/trace_location_organizer_nav_graph.xml
@AlexanderAlferov
Image
0a64704
@AlexanderAlferov AlexanderAlferov added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Aug 12, 2021
@AlexanderAlferov AlexanderAlferov added this to the 2.9.0 milestone Aug 12, 2021
@AlexanderAlferov AlexanderAlferov requested review from a team August 12, 2021 15:08
NataliaLemmerth
NataliaLemmerth approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

mtwalli
mtwalli reviewed Aug 12, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good 👍 , I don't think we need settings in this case

...ain/java/de/rki/coronawarnapp/ui/presencetracing/organizer/TraceLocationOrganizerSettings.kt Outdated Show resolved Hide resolved
@mtwalli mtwalli self-assigned this Aug 12, 2021
This was referenced Aug 12, 2021
Closed
Closed
@jurajkusnier jurajkusnier self-assigned this Aug 13, 2021
jurajkusnier
jurajkusnier reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @mtwalli mentioned we don't need settings.
IMHO in that case code could be much simpler just one static fragment no AutoInject, no ViewModel, no new modules

Corona-Warn-App/src/main/res/layout/trace_location_organizer_warn_info_fragment.xml Show resolved Hide resolved
...e/rki/coronawarnapp/ui/presencetracing/organizer/warn/info/TraceLocationWarnInfoViewModel.kt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jurajkusnier
jurajkusnier approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mtwalli mtwalli merged commit 19a11a8 into feature/8898-event-organizer-warning Aug 13, 2021
@mtwalli mtwalli deleted the feature/8947-warn-info-screen branch August 13, 2021 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@mtwalli mtwalli mtwalli approved these changes

@NataliaLemmerth NataliaLemmerth NataliaLemmerth approved these changes

Assignees

@jurajkusnier jurajkusnier

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexanderAlferov @jurajkusnier @mtwalli @NataliaLemmerth