Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Remove term "Auffrischimpfung" from booster certificate (EXPOSUREAPP-9224) #4002

Merged

Conversation

SamuraiKek
Copy link
Contributor

Booster certificates will be treated and displayed as normal certificates. The term "Auffrischimpfung" is removed from the vaccination cards.

How to test:
Preferably in this order:

cwa vc gen --pii 42 -s v.0.dn=1 v.0.sd=2 v.0.dt='2021-08-24' -e wru
cwa vc gen --pii 42 -s v.0.dn=2 v.0.sd=2 v.0.dt='2021-08-25' -e wru
cwa vc gen --pii 42 -s v.0.dn=3 v.0.sd=3 v.0.dt='2021-08-26' -e wru

…f-booster-vaccination

# Conflicts:
#	Corona-Warn-App/src/main/res/values/covid_certificate_strings.xml
@SamuraiKek SamuraiKek requested review from a team August 31, 2021 09:55
@SamuraiKek SamuraiKek added maintainers Tag pull requests created by maintainers prio PRs to review first. labels Aug 31, 2021
@SamuraiKek SamuraiKek added this to the 2.9.0 milestone Aug 31, 2021
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@mtwalli mtwalli self-assigned this Aug 31, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change the priorities , according to
AC

The exception, that booster vaccinations are not prioritised over the vaccination 2/2 or 1/1 is removed. Instead the latest vaccination has priority over all other vaccinations

Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajkusnier jurajkusnier self-assigned this Aug 31, 2021
@SamuraiKek
Copy link
Contributor Author

I think we need to change the priorities

I have pushed a change but please test with other types of certificates too and make sure the priority didn't get messed up with them.

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.7% 57.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli merged commit 84d8ccd into release/2.9.x Aug 31, 2021
@mtwalli mtwalli deleted the feature/9224-reorganise-treatment-of-booster-vaccination branch August 31, 2021 13:24
@SamuraiKek SamuraiKek changed the title Remove term "Auffrischimpfung" from booster certificate (EXPOSUREAPP-9244) Remove term "Auffrischimpfung" from booster certificate (EXPOSUREAPP-9224) Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants