Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Revert certificates priority changes (EXPOSUREAPP-9277) #4076

Merged

Conversation

SamuraiKek
Copy link
Contributor

@SamuraiKek SamuraiKek commented Sep 15, 2021

Not messing with the priorities anymore. Everything gets back to how it used to be.
As @mlenkeit mentioned in his last comment on the jira ticket: "the "good ol' priority should prioritize a 3/3 booster over a 2/2 VC as long as the date of the vaccination for the booster is after the 2/2 VC (which is fair to assume) (both are covered by the Series-completing Vaccination Certificate > 14 days)"

EDIT: this removes changes made to PersonCertificatesExtensions and PersonCertificatesExtensionsTest made in #4002, #4003 & #4005

@SamuraiKek SamuraiKek requested a review from a team September 15, 2021 10:34
@SamuraiKek SamuraiKek added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Sep 15, 2021
@SamuraiKek SamuraiKek added this to the 2.10.0 milestone Sep 15, 2021
@jurajkusnier jurajkusnier self-assigned this Sep 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli self-assigned this Sep 15, 2021
@mtwalli
Copy link
Contributor

mtwalli commented Sep 15, 2021

Code is reverted to 2.8.0

  • Booster is prioritised
    • cwa vc gen -s v.0.dn=3 v.0.sd=3 v.0.dt='2021-08-30' -e wru --seed mm -o
    • cwa vc gen -s v.0.dn=2 v.0.sd=2 v.0.dt='2021-08-26' -e wru --seed mm -o
    • cwa vc gen -s v.0.dn=1 v.0.sd=2 v.0.dt='2021-08-25' -e wru --seed mm -o

Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajkusnier jurajkusnier merged commit 8be5f9b into release/2.10.x Sep 15, 2021
@jurajkusnier jurajkusnier deleted the fix/9277-vacc-after-recovery-wrong-ranking branch September 15, 2021 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants