Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adapt CollapsingToolbarLayout to end at half height (EXPOSUREAPP-12346) #5065

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

schauersbergern
Copy link
Contributor

Adapt CollapsingToolbarLayout to end at half height
of the first element of the certificates list

@schauersbergern schauersbergern added bug Something isn't working maintainers Tag pull requests created by maintainers labels Apr 7, 2022
@schauersbergern schauersbergern requested a review from a team April 7, 2022 15:15
@schauersbergern schauersbergern changed the title Adapt CollapsingToolbarLayout to end at half height Adapt CollapsingToolbarLayout to end at half height (EXPOSUREAPP-12346) Apr 8, 2022
@SamuraiKek SamuraiKek self-assigned this Apr 8, 2022
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Will approve after rebasing to 2.22

@schauersbergern schauersbergern requested a review from a team April 8, 2022 11:19
@schauersbergern schauersbergern changed the base branch from release/2.21.x to release/2.22.x April 8, 2022 11:21
@schauersbergern
Copy link
Contributor Author

Rebased on 2.22.x and changed target branch

@jurajkusnier jurajkusnier added this to the 2.22.0 milestone Apr 8, 2022
@KathrinLuecke
Copy link
Contributor

Nothing changed in the strings - I don't think UA needs to approve this, right?

@mtwalli
Copy link
Contributor

mtwalli commented Apr 11, 2022

Nothing changed in the strings - I don't think UA needs to approve this, right?

Not required

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chiljamgossow chiljamgossow self-assigned this Apr 11, 2022
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looking good!

@mtwalli mtwalli merged commit db3ac86 into release/2.22.x Apr 12, 2022
@mtwalli mtwalli deleted the fix/12346-flexible-height branch April 12, 2022 07:59
schauersbergern added a commit that referenced this pull request Apr 27, 2022
…6) (#5065)

* Adapt CollapsingToolbarLayout to end at half height
of the first element of the certificates list

* fix indentation

* fix padding

* re add margin to europa image

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants