This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Adapt CollapsingToolbarLayout to end at half height (EXPOSUREAPP-12346) #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauersbergern
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Apr 7, 2022
schauersbergern
changed the title
Adapt CollapsingToolbarLayout to end at half height
Adapt CollapsingToolbarLayout to end at half height (EXPOSUREAPP-12346)
Apr 8, 2022
SamuraiKek
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Will approve after rebasing to 2.22
of the first element of the certificates list
schauersbergern
force-pushed
the
fix/12346-flexible-height
branch
from
April 8, 2022 11:19
409755e
to
1a58f84
Compare
Rebased on 2.22.x and changed target branch |
SamuraiKek
approved these changes
Apr 8, 2022
Nothing changed in the strings - I don't think UA needs to approve this, right? |
Not required |
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looking good!
schauersbergern
added a commit
that referenced
this pull request
Apr 27, 2022
…6) (#5065) * Adapt CollapsingToolbarLayout to end at half height of the first element of the certificates list * fix indentation * fix padding * re add margin to europa image Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt CollapsingToolbarLayout to end at half height
of the first element of the certificates list