Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Text updates for risk-exposures on low-risk level card (EXPOSUREAPP-1737) #937

Merged
merged 4 commits into from
Jul 30, 2020

Conversation

Oliver-Zimmerman
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue [HELP WANTED][README] Text / Translations  #332 for further information)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

Adapted text for low-risk exposures.

Completes Jira task EXPOSUREAPP-1737

@Oliver-Zimmerman Oliver-Zimmerman requested a review from a team July 28, 2020 09:27
@pwoessner pwoessner added fix-sprint2 maintainers Tag pull requests created by maintainers labels Jul 28, 2020
harambasicluka
harambasicluka previously approved these changes Jul 28, 2020
Copy link
Contributor

@vaubaehn vaubaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for lines 139-143 (other, zero, two, few, many) it should be "%1$s Risiko-Begegnungen mit niedrigem Risiko" (plural), if the number of encounters are replacing placeholder "%1$s", right?
If for quantity "zero" the placeholder is replaced with word "keine", then here should stay singular ("Risiko-Begegnung").

Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA Reviewed

@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jakobmoellerdev jakobmoellerdev merged commit 2d0a661 into dev Jul 30, 2020
@jakobmoellerdev jakobmoellerdev deleted the fix/text-updates-low-risk-card branch July 30, 2020 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix-sprint2 maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants