This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix/4235 – Consistent Sorting Of Countries – Alphabetically #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcussc
suggested changes
Dec 14, 2020
| @@ -8,7 +8,7 @@ import UIKit | |||
| struct ExposureSubmissionQRInfoViewModel { | |||
|
|
|||
| init(supportedCountries: [Country]) { | |||
| countries = supportedCountries | |||
| countries = supportedCountries.sorted { $0.localizedName.localizedCompare($1.localizedName) == .orderedAscending } | |||
There was a problem hiding this comment.
Can we put this in an Extension for [Country] ?
extension Array where Element : Country
Something along those lines.
There was a problem hiding this comment.
Cool idea 👍
Done with 8058e6e
nickguendling
approved these changes
Dec 15, 2020
whiskey
suggested changes
Dec 15, 2020
There was a problem hiding this comment.
Thanks for the fix!
Could you please add a simple unit test? Maybe "Germany, Spain and the Netherlands" ordered in these languages. The ordering should change, based on a quick guesstimation from this list of translated country names.
marcussc
approved these changes
Dec 15, 2020
Co-authored-by: Nick Guendling <hello@nickguendling.com>
Added a unit test for sorting countries based on localized country names for all supported languages. |
whiskey
approved these changes
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the inconsistent sorting of country list.
Spec: sort alphabetically.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-4235
Screenshots