This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix/6551 error messages and other bugs #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcussc
approved these changes
Apr 20, 2021
…cwa-app-ios into fix/6551-error-messages * 'fix/6551-error-messages' of github.com:corona-warn-app/cwa-app-ios: missing variable placeholder change of text renaming issues change in folder changes based on feedback add logic adding strings adding tests
naveeddotio
reviewed
Apr 20, 2021
…cwa-app-ios into fix/6551-error-messages * 'fix/6551-error-messages' of github.com:corona-warn-app/cwa-app-ios: Remove some unneeded newlines Add a comment on why Rearrange Backgroundtask reset coordinators when showing onboarding pass route to home after onboarding
naveeddotio
reviewed
Apr 20, 2021
src/xcode/ENA/ENA/Source/Scenes/Home/Cells/TestResult/HomeTestResultCellModel.swift
Show resolved
Hide resolved
naveeddotio
reviewed
Apr 20, 2021
src/xcode/ENA/ENA/Source/Scenes/Home/Cells/TestResult/HomeTestResultCellModel.swift
Show resolved
Hide resolved
naveeddotio
reviewed
Apr 20, 2021
| self?.configureLoading() | ||
| onUpdate() | ||
| if self?.coronaTestService.pcrTest?.finalTestResultReceivedDate == nil { | ||
| if testResultIsLoading { |
There was a problem hiding this comment.
This way it makes a correct english sentence: "If test result is loading [do x]" I admit being inconsistent with this, but would like to keep it that way.
There was a problem hiding this comment.
It's more of a personal style and how you prefer, actually I saw isActivityIndicatorHidden in the next line, so in that context, I found it to be little inconsistent. Anyhow, you have my vote :)
naveeddotio
approved these changes
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes several bugs:
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6525
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6526
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6527
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6550
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6551
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6571