This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/6551 error messages and other bugs #2488
Fix/6551 error messages and other bugs #2488
Changes from all commits
cd9fd84
0fc69c8
3a6df65
7b4ad80
8ce89ee
42e89e8
62d021e
1c2c3e1
8b50911
6cd1450
020791a
153a731
d109bf3
345b592
7c27ab1
edb9242
bb6928e
933971a
63e42da
9357794
ff7acdc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isTestResultLoading ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way it makes a correct english sentence: "If test result is loading [do x]" I admit being inconsistent with this, but would like to keep it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more of a personal style and how you prefer, actually I saw isActivityIndicatorHidden in the next line, so in that context, I found it to be little inconsistent. Anyhow, you have my vote :)