Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

[Lint] Fixes some trivial SwiftLint warnings #516

Closed
wants to merge 2 commits into from

Conversation

Jeehut
Copy link

@Jeehut Jeehut commented Jun 11, 2020

Description

This is the first follow-up smaller PR to #104. Together with the other PRs I will be posting, all SwiftLint warnings should be fixed to allow us to enable the --strict mode of SwiftLint on the CI to prevent any new warnings getting merged in the future.

Related PRs

#518, #522, #527, #531, #534.

Note that all these PRs are completely independent and can be merged in any order.

@Jeehut Jeehut requested a review from a team June 11, 2020 17:15
@Jeehut Jeehut changed the title Fixes some trivial SwiftLint warnings [Lint] Fixes some trivial SwiftLint warnings Jun 11, 2020
@Jeehut Jeehut force-pushed the feature/cg_swiftlint-1 branch 3 times, most recently from c99f754 to 4cfc6d7 Compare June 11, 2020 18:30
@ChristianKienle
Copy link
Contributor

Thank you very much for this PR. I will put this on hold for the next couple of days because we are in a critical phase in the project at the moment. I hope you understand. We will come back to you once this phase is over.

@Jeehut
Copy link
Author

Jeehut commented Jun 12, 2020

@ChristianKienle
I'm waiting since 11 days now (see #104) to get these SwiftLint warnings fixed and I'm not even changing any logic here. I decided to start with this part because it's a no-brainer to get them merged, but if even these PRs are being put on hold - again - then I'm really worried about the overall community aspect of this project ...

@inf2381 inf2381 changed the base branch from development to next June 14, 2020 09:29
@inf2381 inf2381 closed this Jun 19, 2020
@inf2381 inf2381 reopened this Jun 19, 2020
@inf2381 inf2381 changed the base branch from next to develop June 19, 2020 09:04
@marcussc
Copy link
Contributor

@Jeehut
Sorry for the late response. We decided to close this PR due to two Reasons:

  • The PR can`t be merged since there have already been changes in our SwiftLint config
  • We will clean up our Project/SwitLint Rules in the next 2 Week-Sprint (starting 30th Sept.) with the Goal to have 0 Warnings coming from SwiftLint.

Sorry again for the late response and the now resulting close of this PR.

@marcussc marcussc closed this Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants