This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
[Chore] Split background tasks on develop branch #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added separate task for fetch-test-results back into app - Use generic $(PRODUCT_BUNDLE_IDENTIFIER) taskID in Info.plist - Use Bundle.main.bundleIdentifier as prefix in ENATaskScheduler - Ensure execute functions are handled separately
…it-background-tasks-on-develop-branch * fix/split-background-tasks-on-development: Use generic $(PRODUCT_BUNDLE_IDENTIFIER) taskID in Info.plist Split out execution of background tasks into separate tasks: - Added separate task for fetch-test-results back into app - Use generic $(PRODUCT_BUNDLE_IDENTIFIER) taskID in Info.plist - Use Bundle.main.bundleIdentifier as prefix in ENATaskScheduler - Ensure execute functions are handled separately # Conflicts: # src/xcode/ENA/ENA/Source/Models/Task Scheduling/ENATaskScheduler.swift
inf2381
changed the title
* develop: fix wrong url Bring back non-breakable whitespaces Removed duplicate table entry further clarification Prominently add feature requests target Add visible not about closing PRs w/o issue assigned Add explicit link to cwa-wishlist repo Clarify contribution guidelines [INTERNAL] Translation delivery: commit by LX Lab [INTERNAL] Translation delivery: commit by LX Lab fixed risk view [INTERNAL] Translation delivery: commit by LX Lab
ChristianKienle
approved these changes
Jun 22, 2020
johannesrohwer
approved these changes
Jun 23, 2020
src/xcode/ENA/ENA/Source/Models/Task Scheduling/ENATaskScheduler.swift
Outdated
Show resolved
Hide resolved
src/xcode/ENA/ENA/Source/Models/Task Scheduling/ENATaskScheduler.swift
Outdated
Show resolved
Hide resolved
src/xcode/ENA/ENA/Source/Models/Task Scheduling/ENATaskScheduler.swift
Outdated
Show resolved
Hide resolved
src/xcode/ENA/ENA/Source/Models/Task Scheduling/ENATaskScheduler.swift
Outdated
Show resolved
Hide resolved
| @@ -62,12 +66,18 @@ final class ENATaskScheduler { | |||
|
|
|||
| func scheduleTasks() { | |||
| scheduleTask(for: .primaryBackgroundTask, cancelExisting: true) | |||
| scheduleTask(for: .secondaryBackgroundTask, cancelExisting: true) | |||
| } | |||
|
|
|||
| func cancelTasks() { | |||
| BGTaskScheduler.shared.cancelAllTaskRequests() | |||
There was a problem hiding this comment.
If you cancel all task requests, doesn't it mean that you would be canceling the secondaryBackgroundTask from the primaryBackgroundTask and vice versa? Do you really want this?
Nevermind, I misread.
melloskitten
suggested changes
Jun 23, 2020
Renamed secondaryBackgroundTask to fetchTestResults Fixed typo for taskHander to taskHandler
|
Looks awesome! Thanks a lot! 🎈 🥳 |
melloskitten
approved these changes
Jun 23, 2020
haosap
reviewed
Jun 23, 2020
Comment on lines
+7
to
+8
| <string>$(PRODUCT_BUNDLE_IDENTIFIER).exposure-notification</string> | ||
| <string>$(PRODUCT_BUNDLE_IDENTIFIER).fetch-test-results</string> |
There was a problem hiding this comment.
why do you replace it with the environment var?
There was a problem hiding this comment.
i guess its done to make sure there are no collisions with different app versions, e.g. one that was installed via test flight vs. a debug build? (e.g. the debug target uses de.rki.coronawarnapp-dev, production targets use de.rki.coronawarnapp)
There was a problem hiding this comment.
It allows us to use the app bundle ID as the prefix for the identifier. In the code, we use Bundle.main.bundleIdentifier as the prefix. This means that we can deploy either app targets during dev (eg from 'de.rki.coronawarnapp' to 'de.rki.coronawarnapp-dev'), and ensure that background tasks from one instance will not collide with the other app's background task identifiers. It's also the method used by Apple's sample code for exposure notifications.
* develop: (39 commits) Fixed the height of Update button on Exposure Detection screen. Apply ENAFooterView to invite friends controller. Added full ENAButton dynamic type support. Removed ENACloneButton. Fixed lost navigation item observer when dismissing modal presentation. Minor fix. Disabled next button when sharing keys. Fixed ENATanInput bottom line visibility when entering text. Fixed fragile TAN input first responder handling for error state. Fixed spinner animation when injecting. Updated tests. Fixed IB warning. Improved share text. Add missing label Update pr guidelines Switch to grenrc.js Update gren config Bump version Integrate gren for release notes Removed deprecated file. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the operation of the background tasks.
Previously, the background task only triggered once every 4 hours minimum. On triggering the task, the fetch-test-results API call is executed, and on completion, the exposure-detection API call is executed, effectively executing the two API asynchronous calls in series.
This change splits the execution of the API calls into two separate tasks. This allows the exposure detection call to maintain the higher priority, and adhere to the minimum timing specified by the ExposureNotification framework.
No changes have been made to the logic to determine whether to bypass the API calls, which are still driven by the RiskProvider class (for the exposure-detection API call) and the ENAExposureSubmissionService class (for the fetch-test-results API call)