Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Update docs reg. EFGS shut down (Addresses #514) #946

Closed
wants to merge 3 commits into from
Closed

Update docs reg. EFGS shut down (Addresses #514) #946

wants to merge 3 commits into from

Conversation

Ein-Tim
Copy link
Contributor

@Ein-Tim Ein-Tim commented Mar 14, 2023

This PR updates the solution_architecture.md document reg. the EFGS shut down. It adds a note to the start of the respective paragraph.


Fixes #514

This commit updates the solution_architecture.md document reg. the EFGS shut down. It adds a note to the start of the respective paragraph.
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments!

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Apr 1, 2023

@Ein-Tim

Do you want to continue with this PR? Nobody has picked it up and now it is documented in the FAQs anyway What happens to the EFGS for cross-country risk determination? How long will this service continue to run?

image

To be consistent you would need to add other ramp-down dates into the architecture document. It is probably better not to add any dates into the solution_architecture.md document though.

Edit: The references to teleTAN in the document are also obsolete, due to the shutdown of the TAN Hotline (see TAN Procedure). This is not mentioned in the solution_architecture.md. This is the reason I say it would be inconsistent to mention about the shutdown of the EFGS without mentioning the shutdown of the TAN Hotline.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 1, 2023

@MikeMcC399

Thank you for the reminder!

I still think that this is a good addition and would like to ask @dsarkar / @larswmh / @brianebeling to take a look at this!

@GisoSchroederSAP
Copy link

GisoSchroederSAP commented Apr 1, 2023

One quick comment: teleTAN and TAN hotline are under control and responsibility of TSI; they have and claim (by legal means) a different "communication pattern" (I have no better phrase, sorry). I'll take your comment to the next possible meeting. Let's see what the outcome will be. At least, we are not entitled to communicate about these activities without permission.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 1, 2023

@GisoSchroederSAP This PR does not include any changes reg. TANs or the teleTAN hotline, so I'm not sure what you mean, sorry!

@MikeMcC399
Copy link
Contributor

I'm sorry if my comments caused confusion and I don't really understand #946 (comment) from @GisoSchroederSAP.

My point is that the document solution_architecture.md is purely an architecture document which makes no reference to the introduction or withdrawal of any features, which is why I think that this PR should not be implemented.

On April 30, 2023 all of the features from the solution_architecture.md will in any case be withdrawn. This point is already covered by the pinned issue #948 from @larswmh.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 2, 2023

@MikeMcC399 Okay, I understand your point, reg. that this is a pure architecture document and that it doesn't reflect when features are implemented or when they are shutdown. I will leave this PR open so that the team can consider it, but I think your point is valuable, and it is ok for me if this PR is not merged!

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 25, 2023

@GisoSchroederSAP Can we expect further feedback here?

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Apr 25, 2023

@Ein-Tim

I suggest you close this PR.

To follow your logic of wanting to document the shutdown of the EFGS, you would need to follow-up now due to the connection to test centres being deactivated on April 20, 2023 and again on May 1, 2023 and modify the document once again, citing all the other servers which have been shut down. Then to make the rest of the repository consistent, you would need to modify many of the other documents accordingly.

The https://github.com/corona-warn-app/.github/blob/main/profile/README.md document can be used to pass a general message concerning all repositories affected by the ramp-down. This could mention which repository contents are still valid, or repositories could be set to archive status. Much of the information in the various README files will no longer be accurate after ramp-down and project closure.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 25, 2023

@MikeMcC399 I agree with you, but I will not close this PR without having received further feedback from the team on what's the plan.

@MikeMcC399
Copy link
Contributor

@Ein-Tim

What plan are you looking for? What should the plan cover? It sounds like this should be a separate topic, since you already agreed that the PR should be closed.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 26, 2023

I'd just like to receive feedback on how the team will handle document updates after the app's shutdown. I will consider opening a new issue for this, but if we could get feedback here, that's also fine for me.

@MikeMcC399
Copy link
Contributor

@Ein-Tim

I'd just like to receive feedback on how the team will handle document updates after the app's shutdown. I will consider opening a new issue for this, but if we could get feedback here, that's also fine for me.

Considering that there have been no developer updates in this repository for the last 6 months I would be surprised if that changed in the remaining weeks until the official end of development milestone on May 31, 2023. Of course, you are entitled to pose the question, although this is a much more general question than the single topic about the EFGS server.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Apr 30, 2023

I will follow up in a separate issue or raise this issue internally.

@Ein-Tim Ein-Tim closed this Apr 30, 2023
@Ein-Tim Ein-Tim deleted the update/EFGS-shutdown branch April 30, 2023 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that the user doesn't have to select any countries for the EFGS and describe the 3 modes
3 participants