Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Add social media icons and community section #2284

Merged

Conversation

brifemu
Copy link
Contributor

@brifemu brifemu commented Jan 5, 2022

In this PR, I have merged all the changes made in the last month about social media stuff.

Open-Source-Project-Corona-Warn-App-Community (1)

@brifemu brifemu requested a review from a team January 5, 2022 16:10
@cwa-bot cwa-bot bot added this to ToDo in [CM] cwa-website Jan 5, 2022
@dsarkar dsarkar self-assigned this Jan 5, 2022
@dsarkar dsarkar added the documentation Improvements or additions to documentation label Jan 5, 2022
@cwa-bot cwa-bot bot moved this from ToDo to Mirrored to Jira in [CM] cwa-website Jan 5, 2022
src/data/community.json Outdated Show resolved Hide resolved
src/data/community.json Outdated Show resolved Hide resolved
src/data/global.json Outdated Show resolved Hide resolved
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to in-line comments

Add `rel='noopener noreferrer' to external hyperlinks with target _blank

@dsarkar
Copy link
Member

dsarkar commented Jan 5, 2022

@MikeMcC399 Thanks for the review, enjoy your evening!

@MikeMcC399
Copy link
Contributor

@dsarkar

Thanks for the review, enjoy your evening!

You are very welcome! The same to you for a relaxed evening! 🙂

@larswmh
Copy link
Member

larswmh commented Jan 6, 2022

Thanks for your comments @MikeMcC399! Apart from your in-line suggestions, I have added rel='noopener noreferrer' to both the Twitter and Instagram links in each language in the latest commit.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 6, 2022

FYI: corona-warn-app/cwa-app-ios#4049 seems like this page will be mentioned in the app starting with version 2.17.

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larswmh
Thanks for considering all my comments!

It looks good to publish now.

@dsarkar
Copy link
Member

dsarkar commented Jan 6, 2022

@MikeMcC399 and everybody! Thanks for the reviews and work. Should be merged shortly.

@dsarkar dsarkar merged commit 8f4ac8d into corona-warn-app:master Jan 7, 2022
@cwa-bot cwa-bot bot moved this from Mirrored to Jira to Done in [CM] cwa-website Jan 7, 2022
@dsarkar dsarkar deleted the brifemu-social-media-bootstrap branch January 7, 2022 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation mirrored-to-jira
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants