Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

DCC german template with pdf only #143

Merged
merged 8 commits into from
Jul 26, 2021
Merged

DCC german template with pdf only #143

merged 8 commits into from
Jul 26, 2021

Conversation

bergmann-dierk
Copy link
Contributor

New Pull Requests with changes concerning PDF DCC generation for CWA users.
DCC Page of PDF is appended after DccUploadResult is received and qrCode string is generated successfully.

Unittest Example:
unittestCert.pdf

@dsarkar
Copy link
Member

dsarkar commented Jul 20, 2021

@bergmann-dierk see issue corona-warn-app/cwa-documentation#644 regarding the format of the template. I think the QR code is now placed away from the border, displayed larger etc.

See also these templates: https://github.com/Digitaler-Impfnachweis/certification-apis/tree/master/templates

In short, to prevent issues regarding QR code scanning, as they were observed already on similar documents, the following has been implemented corona-warn-app/cwa-documentation#644 (comment):

Summary:

  1. Position of the QR code is to close to the edge edge of paper -> reposition away from the edge
  2. Size of the QR code is too small, see e.g. Suggestion to modify DE EU Digital Covid Vaccination Certificate format cwa-documentation#644 (comment) and Suggestion to modify DE EU Digital Covid Vaccination Certificate format cwa-documentation#644 (comment) -> increase size
  3. The QR code should be placed on a white frame, see Suggestion to modify DE EU Digital Covid Vaccination Certificate format cwa-documentation#644 (comment) . (This may be referred to as a margin in some QR code generators.) This might be root cause for paper QR Code not readable cwa-app-android#3514 (comment)
  4. High error correction level in the QR code

@vaubaehn
Copy link

@dsarkar good catch - thanks that you took care of this!

@dsarkar
Copy link
Member

dsarkar commented Jul 23, 2021

@vaubaehn actually, some credits should go to @Ein-Tim, since he mentioned this PR in our wishlist repository and that's what directed my attention here. So thanks also to @Ein-Tim!

@ascheibal ascheibal merged commit 44d15c1 into master Jul 26, 2021
@ascheibal ascheibal added the enhancement New feature or request label Jul 27, 2021
@mschulte-tsi mschulte-tsi deleted the feat/dcc-pdf branch August 13, 2021 06:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants