This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmann-dierk
requested review from
a-trzewik,
agaricusbisporus,
AnnotationGuyTest,
ascheibal,
bjarne1337,
BugBuster1701,
f11h,
fOppenheimer,
ggrund-tsi,
mbaude and
mschulte-tsi
as code owners
July 20, 2021 11:43
@bergmann-dierk see issue corona-warn-app/cwa-documentation#644 regarding the format of the template. I think the QR code is now placed away from the border, displayed larger etc. See also these templates: https://github.com/Digitaler-Impfnachweis/certification-apis/tree/master/templates In short, to prevent issues regarding QR code scanning, as they were observed already on similar documents, the following has been implemented corona-warn-app/cwa-documentation#644 (comment): Summary:
|
@dsarkar good catch - thanks that you took care of this! |
ascheibal
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Requests with changes concerning PDF DCC generation for CWA users.
DCC Page of PDF is appended after DccUploadResult is received and qrCode string is generated successfully.
Unittest Example:
unittestCert.pdf