Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Draft changes with failure test DiagnosisKeyUploadIT #1392

Merged
merged 6 commits into from
May 19, 2021

Conversation

ioangut
Copy link
Contributor

@ioangut ioangut commented May 18, 2021

Description

Fix upload keys for efgs/chgs.

hilmarf
hilmarf previously approved these changes May 18, 2021
@hilmarf hilmarf added this to the 2.3 milestone May 18, 2021
@ioangut ioangut changed the base branch from main to release/2.3 May 18, 2021 17:58
@ioangut ioangut dismissed hilmarf’s stale review May 18, 2021 17:58

The base branch was changed.

@hilmarf hilmarf linked an issue May 19, 2021 that may be closed by this pull request
f11h
f11h previously approved these changes May 19, 2021
conflicting keys will be updated with batchtag and not re-send
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hilmarf hilmarf marked this pull request as ready for review May 19, 2021 08:23
@hilmarf hilmarf merged commit 930d183 into release/2.3 May 19, 2021
@hilmarf hilmarf deleted the fix-upload-efgs-keys branch May 19, 2021 08:27
hilmarf added a commit that referenced this pull request May 19, 2021
* release 2.3

* Draft changes with failure test DiagnosisKeyUploadIT (#1392)

* Draft changes with failure test DiagnosisKeyUploadIT

* Draft changes with failure test DiagnosisKeyUploadIT

* batches with conflicting keys are rolled back

as per comment from @f11h -
#1391 (comment)

* success keys, have to be re-send and should not get updated

conflicting keys will be updated with batchtag and not re-send

* DiagnosisKeyUploadIT

Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>

* Use main maven revision version

Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>
@hilmarf hilmarf mentioned this pull request May 27, 2021
hilmarf added a commit that referenced this pull request Jun 4, 2021
* release 2.3

* Draft changes with failure test DiagnosisKeyUploadIT (#1392)

* Draft changes with failure test DiagnosisKeyUploadIT

* Draft changes with failure test DiagnosisKeyUploadIT

* batches with conflicting keys are rolled back

as per comment from @f11h -
#1391 (comment)

* success keys, have to be re-send and should not get updated

conflicting keys will be updated with batchtag and not re-send

* DiagnosisKeyUploadIT

Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>

* fix: add support for fetching batch info by source system and status (release 2.3) (#1414)

* fix: add support for fetching batch info by source system and status

* revision=2.3.1

Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>

* adjust primary key (#1416)

when we store the batches of two different systems (EFGS/CHGS), we
should adjust our primary key!

* UPDATE - count and delete for date in BatchInfoRepository to take in consideration source system (#1418)

Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com>
Co-authored-by: FelixRottler <72494737+FelixRottler@users.noreply.github.com>
Co-authored-by: alexmoroianu <32899407+alexmoroianu@users.noreply.github.com>
hilmarf added a commit that referenced this pull request Jun 4, 2021
* release 2.4

* Merge/2.3 2.4 (#1419)

* release 2.3

* Draft changes with failure test DiagnosisKeyUploadIT (#1392)

* Draft changes with failure test DiagnosisKeyUploadIT

* Draft changes with failure test DiagnosisKeyUploadIT

* batches with conflicting keys are rolled back

as per comment from @f11h -
#1391 (comment)

* success keys, have to be re-send and should not get updated

conflicting keys will be updated with batchtag and not re-send

* DiagnosisKeyUploadIT

Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>

* fix: add support for fetching batch info by source system and status (release 2.3) (#1414)

* fix: add support for fetching batch info by source system and status

* revision=2.3.1

Co-authored-by: Hilmar Falkenberg <hilmar.falkenberg@sap.com>

* adjust primary key (#1416)

when we store the batches of two different systems (EFGS/CHGS), we
should adjust our primary key!

* UPDATE - count and delete for date in BatchInfoRepository to take in consideration source system (#1418)

Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com>
Co-authored-by: FelixRottler <72494737+FelixRottler@users.noreply.github.com>
Co-authored-by: alexmoroianu <32899407+alexmoroianu@users.noreply.github.com>

* revision=2.5.0-SNAPSHOT

* fix order of log parameters

Co-authored-by: ioangut <67064882+ioangut@users.noreply.github.com>
Co-authored-by: FelixRottler <72494737+FelixRottler@users.noreply.github.com>
Co-authored-by: alexmoroianu <32899407+alexmoroianu@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong EFGS Response Handling
7 participants