Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apk can be installed locally #3456

Merged
merged 2 commits into from
Apr 11, 2023
Merged

fix: apk can be installed locally #3456

merged 2 commits into from
Apr 11, 2023

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Apr 4, 2023

This PR corrects the definition of an Android APK, which is a single file containing all of the app code and which can be installed independently of access to the Google Play Store.

It resolves one aspect of issue #3449 and changes:


Internal Tracking ID: EXPOSUREAPP-15017

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 4, 2023 06:57
@MikeMcC399 MikeMcC399 requested a review from a team April 4, 2023 06:57
Copy link
Contributor

@GisoSchroederSAP GisoSchroederSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, small change for an acceptable solution, thanks a million!
Approved.

@MikeMcC399
Copy link
Contributor Author

@GisoSchroederSAP

Great, small change for an acceptable solution, thanks a million!
Approved.

Thank you for your approval. Will you now merge this PR?

Copy link
Contributor

@Ein-Tim Ein-Tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side!

@MikeMcC399
Copy link
Contributor Author

Is there some reason for not merging this correction?

@dsarkar
Copy link
Member

dsarkar commented Apr 11, 2023

@MikeMcC399 Thanks, will be merged!

@larswmh larswmh merged commit d497af6 into corona-warn-app:master Apr 11, 2023
@MikeMcC399 MikeMcC399 deleted the fix/apk-definition branch April 11, 2023 08:16
@larswmh larswmh mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants