Fixed bug which was causing an unwanted "a" key event. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he screenshot tool in MacOS.
|
|
|
Thanks a lot! You submitted first ever community fix. Congrats and much gratitude! I also noticed that window doesn't get key-up events, but I guess it's not much can be done with it. |
Shchvova
added a commit
that referenced
this pull request
Jun 21, 2021
ggcrunchy
pushed a commit
to ggcrunchy/corona
that referenced
this pull request
Jul 8, 2021
Shchvova
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug happened when using the screenshot tool in MacOS. Simply handled it by just ignoring the event when the keyCode = kVK_ANSI_A because this shouldn't even happen in the 'flagsChanged' method.
Steps to reproduce the original bug: Simply add a "key" listener in the main.lua and print the keyName & phase. Start the simulator and create a screenshot with "cmd + shift + 4". Runtime:addEventListener("key", function(event) print(event.keyName, event.phase) end)