Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI for feedback #54

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Added UI for feedback #54

merged 9 commits into from
Sep 5, 2023

Conversation

khavinshankar
Copy link
Member

Resolves coronasafe/ayushma#75

The UI includes,

  • thumbs up and down icons for rating
    image

  • modal for giving additional feedback
    image

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ayushma-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 4:03am

Copy link
Member

@skks1212 skks1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar

  • All is perfect, just the page is reloading after submit.
  • Can we have regular icons for thumbs up/down? far instead or fal. Also they don't have a cursor-pointer
  • If a popup opens after hovering on the given feedback icon containing the message it would be nice.
    image
  • Deploy preview is failing can you look into it?

@khavinshankar
Copy link
Member Author

@khavinshankar

  • All is perfect, just the page is reloading after submit.
  • Can we have regular icons for thumbs up/down? far instead or fal. Also they don't have a cursor-pointer
  • If a popup opens after hovering on the given feedback icon containing the message it would be nice.
    image
  • Deploy preview is failing can you look into it?
  • added a state instead of reloading the page
  • changed fal to far, and added cursor pointer
  • added a tooltip for feedback messages on hover
image

@khavinshankar
Copy link
Member Author

@skks1212 I'm not able to see the vercel logs, can u add me in that or can u take a screenshot and post it here

@skks1212
Copy link
Member

skks1212 commented Jul 3, 2023

@khavinshankar Cannot add you to team, Mathew can. Here are the logs:
image

Is next lint not detecting this? Or is husky not configured properly?

@bodhish
Copy link
Member

bodhish commented Aug 23, 2023

@khavinshankar @Ashesh3 do review

@Ashesh3
Copy link
Member

Ashesh3 commented Aug 23, 2023

@khavinshankar could you resolve the minor merge conflicts, we'll test and get it merged as soon as they are cleared.

@skks1212 skks1212 merged commit 8686a12 into master Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ayushma: Add Feedback
4 participants