Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit fails while trying to commit the changes that we made, [un-used imports on various files] #417

Closed
muhammed-ajmal opened this issue Jun 27, 2020 · 0 comments · Fixed by #836
Closed

pre-commit fails while trying to commit the changes that we made, [un-used imports on various files] #417

muhammed-ajmal opened this issue Jun 27, 2020 · 0 comments · Fixed by #836
Assignees
@sainak
Labels
backlog
Projects
Care Care

Comments

@muhammed-ajmal
Copy link
Contributor

pre-commit failures

  • imported but unused [ on various files ]
  • invalid escape sequence
  • undefined names, E722 do not use bare 'except' ..etc

currently for commiting changes we need to use --no-verify flag to get override these

Screenshot from 2020-06-27 23-52-32

Screenshot from 2020-06-27 23-54-22
@muhammed-ajmal muhammed-ajmal changed the title pre-commit fails while trying to commit the changes , we made, [un-used imports on various files] pre-commit fails while trying to commit the changes that we made, [un-used imports on various files] Jun 27, 2020
@bodhish bodhish added this to To do in Care Jun 28, 2020
@bodhish bodhish added this to wishlist in Care Jun 28, 2020
@sainak sainak assigned sainak and unassigned vigneshhari Jun 7, 2022
@sainak sainak mentioned this issue Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainak sainak

Labels
backlog
Projects
Care
Archived in project
Care
  
To do
Care
wishlist
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update pre-commit hooks and dependencies coronasafe/care
4 participants
@tomahawk-pilot @vigneshhari @muhammed-ajmal @sainak