Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pre-commit hooks and dependencies #836

Merged
merged 2 commits into from
Jun 9, 2022
Merged

update pre-commit hooks and dependencies #836

merged 2 commits into from
Jun 9, 2022

Conversation

sainak
Copy link
Member

@sainak sainak commented Jun 7, 2022 •
edited
Loading

use common code style everywhere

removed

  • pycodestyle
  • pylint

closes #417

@sainak sainak requested a review from a team as a code owner June 7, 2022 13:43
@sainak
Copy link
Member Author

sainak commented Jun 7, 2022

@vigneshhari add https://pre-commit.ci/ to the repo

@vigneshhari
Copy link
Member

@sainak the app requires write access to the code, so the app won't be installed. we can keep tabs on it.

@vigneshhari vigneshhari merged commit 23c81d1 into master Jun 9, 2022
@sainak sainak deleted the sainak/fix/code-quality branch June 10, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit fails while trying to commit the changes that we made, [un-used imports on various files]
2 participants
@sainak @vigneshhari