add dry permissions for facility cover_image #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainak
commented
Sep 5, 2022
sainak
force-pushed
the
sainak/fix/facility-cover-upload
branch
from
dd2668d
to
72d3928
Compare
sainak
force-pushed
the
sainak/fix/facility-cover-upload
branch
from
72d3928
to
16cb31d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vigneshhari
requested changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix was to add object level dry permissions for cover_image route and relaxing model level permissions as we weren't sending district, state or lsb fields
The code was also refactored to improve api documentation