Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete cached asset object only on update #1013

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 8, 2022

Proposed Changes

delete cached asset object only on update

closes #1012
fixes ohcnetwork/care_fe#3561

@coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner September 8, 2022 21:25
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #1013 (f2c5bce) into master (6bd66bf) will decrease coverage by 1.28%.
The diff coverage is 48.03%.

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
- Coverage   54.02%   52.74%   -1.29%     
==========================================
  Files         182      183       +1     
  Lines        8990     8921      -69     
==========================================
- Hits         4857     4705     -152     
- Misses       4133     4216      +83     
Impacted Files Coverage Δ
care/facility/api/viewsets/patient.py 47.90% <0.00%> (-0.34%) ⬇️
...re/facility/management/commands/scrape_icd_data.py 0.00% <0.00%> (ø)
care/facility/models/file_upload.py 68.88% <0.00%> (ø)
care/facility/models/json_schema/asset.py 100.00% <ø> (ø)
care/facility/models/patient.py 88.09% <ø> (-6.75%) ⬇️
care/facility/static_data/icd11.py 0.00% <0.00%> (ø)
care/users/api/viewsets/users.py 42.94% <0.00%> (-12.90%) ⬇️
care/utils/assetintegration/onvif.py 38.23% <ø> (+1.09%) ⬆️
config/settings/deployment.py 0.00% <ø> (ø)
config/settings/local.py 0.00% <0.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sainak sainak added the P1 High priority; urgent label Sep 9, 2022
@Ashesh3
Copy link
Member

Ashesh3 commented Sep 9, 2022

Fixes ohcnetwork/care_fe#3561

@nihal467
Copy link
Member

nihal467 commented Sep 9, 2022

@vigneshhari can you check this ASAP

@vigneshhari vigneshhari merged commit 527f585 into master Sep 9, 2022
@sainak sainak deleted the sainak/fix/issue1012 branch September 9, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create a new asset for a facility AttributeError: 'NoneType' object has no attribute 'external_id'
5 participants