Add serializer constraints to AssetBed #1018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* HL7Monitor Assets can have only 1 Bed Associated with it. * Assets that are neither HL7Monitor nor ONVIFCamera should not have Bed Relations
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
- Coverage 54.02% 53.78% -0.25%
==========================================
Files 182 180 -2
Lines 8990 8921 -69
Branches 0 1523 +1523
==========================================
- Hits 4857 4798 -59
+ Misses 4133 4074 -59
- Partials 0 49 +49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sainak
changed the title
sainak
approved these changes
Sep 9, 2022
|
@Krishna-Sivakumar Make sure that you specify the issue you're solving |
vigneshhari
reviewed
Oct 7, 2022
| elif ( | ||
| asset.asset_class != "HL7MONITOR" | ||
| and asset.asset_class != "ONVIF" | ||
| and asset.bed_set.all().count() > 0 |
There was a problem hiding this comment.
Not really sure why this condition is here.
vigneshhari
reviewed
Oct 7, 2022
| @@ -82,6 +82,23 @@ def validate(self, attrs): | |||
| raise ValidationError( | |||
| {"asset": "Should be in the same facility as the bed"} | |||
| ) | |||
|
|
|||
| if asset.asset_class == "HL7MONITOR" and asset.bed_set.all().count() > 1: | |||
There was a problem hiding this comment.
shouldn't we also check for = 1 as well ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #934
Proposed Changes
AssetBed Serializer was updated to validate the following constraints:
@coronasafe/code-reviewers
Merge Checklist