Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added medicine_administration field #1025

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Conversation

skks1212
Copy link
Member

A JSON field to host data for Medicine Administration Record in Daily rounds, a new proposed feature as mentioned in coronasafe/care_fe#3437

@skks1212 skks1212 requested a review from a team as a code owner September 17, 2022 16:06
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.97% // Head: 55.99% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (54f4725) compared to base (3d8dfa1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   55.97%   55.99%   +0.02%     
==========================================
  Files         171      171              
  Lines        8555     8559       +4     
  Branches     1459     1474      +15     
==========================================
+ Hits         4789     4793       +4     
  Misses       3717     3717              
  Partials       49       49              
Impacted Files Coverage Δ
care/facility/models/daily_round.py 88.71% <100.00%> (+0.11%) ⬆️
care/facility/models/json_schema/daily_round.py 100.00% <100.00%> (ø)
care/users/api/viewsets/change_password.py 61.53% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -435,6 +435,10 @@ class InsulinIntakeFrequencyType(enum.Enum):
default=list, validators=[JSONFieldSchemaValidator(NURSING_PROCEDURE)]
)

medicine_administration = JSONField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a JSON schema for this as well? having a schemaless field might get hard for standardization at some point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON schema for this is going to be very complex. It has still not been finalized. Once it will, I will add the schema in the backend as another PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okays, make an issue and tag it here even if this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants