Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(minor) updated installation guide #1074

Merged
merged 2 commits into from
Oct 25, 2022
Merged

(minor) updated installation guide #1074

merged 2 commits into from
Oct 25, 2022

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Oct 23, 2022

Proposed Changes

  • updated installation guide
    Added guideline to add the environment variable to read from the .env file which was missing initially
  • Also updated the dummy data where there was a ward id mismatch
    image

Associated Issue

  • none

Architecture changes

  • none

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@khavinshankar khavinshankar requested a review from a team as a code owner October 23, 2022 03:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Base: 55.92% // Head: 55.99% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (b464a04) compared to base (f9a21dc).
Patch coverage: 76.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   55.92%   55.99%   +0.07%     
==========================================
  Files         175      175              
  Lines        8655     8678      +23     
  Branches     1464     1483      +19     
==========================================
+ Hits         4840     4859      +19     
- Misses       3763     3767       +4     
  Partials       52       52              
Impacted Files Coverage Δ
care/facility/models/daily_round.py 81.30% <0.00%> (+0.37%) ⬆️
care/facility/models/json_schema/daily_round.py 100.00% <ø> (ø)
care/users/api/viewsets/users.py 53.08% <33.33%> (-0.76%) ⬇️
...are/facility/models/mixins/permissions/facility.py 51.85% <66.66%> (+0.87%) ⬆️
care/facility/api/viewsets/asset.py 55.88% <100.00%> (+3.65%) ⬆️
config/settings/test.py 100.00% <100.00%> (ø)
care/users/api/viewsets/change_password.py 61.53% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit 5bde4b6 into master Oct 25, 2022
@sainak sainak deleted the contributing-patch-1 branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants