Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added is_occupied read-only field in Bed #1083

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Added is_occupied read-only field in Bed #1083

merged 1 commit into from
Oct 28, 2022

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Oct 28, 2022 •
edited
Loading

Fixes #1082

Proposed Changes

  • Added is_occupied read-only field in Bed
    This is required to filter beds based on weather it is occupied or not

Associated Issue

Architecture changes

  • none

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@khavinshankar khavinshankar requested a review from a team as a code owner October 28, 2022 08:13
@khavinshankar khavinshankar linked an issue Oct 28, 2022 that may be closed by this pull request
Add is_occupied read_only field to bed #1082
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar mentioned this pull request Oct 28, 2022
Merged
6 tasks
@vigneshhari
Copy link
Member

I would rather create a variable and store it in the database, this method fires a query per object retrieval, which can be DB intensive when multiple objects are rendered. @khavinshankar can you create a separate ticket for this.
I will approve this on the condition that it will be improved later.

@vigneshhari vigneshhari merged commit 2b6c282 into master Oct 28, 2022
@khavinshankar khavinshankar mentioned this pull request Oct 28, 2022
Open
@sainak sainak deleted the feat#1082 branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add is_occupied read_only field to bed
2 participants
@khavinshankar @vigneshhari