Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made icd search case insensitive #1085

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • Made icd11 diagnoses search case insensitive

Associated Issue

Architecture changes

  • none

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@khavinshankar khavinshankar requested a review from a team as a code owner October 29, 2022 14:58
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.97% // Head: 55.98% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7f13c8b) compared to base (5bde4b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   55.97%   55.98%   +0.01%     
==========================================
  Files         175      175              
  Lines        8681     8686       +5     
  Branches     1483     1483              
==========================================
+ Hits         4859     4863       +4     
- Misses       3770     3771       +1     
  Partials       52       52              
Impacted Files Coverage Δ
care/facility/api/viewsets/icd.py 40.00% <100.00%> (+3.15%) ⬆️
care/facility/models/bed.py 82.05% <0.00%> (-1.29%) ⬇️
care/facility/api/serializers/bed.py 41.73% <0.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari
Copy link
Member

Any difference in performance ?

@vigneshhari vigneshhari merged commit eb52c8a into master Nov 1, 2022
@sainak sainak deleted the icd11-search-case-insensitive branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants