Added is_occupied field in Bed

[khavinshankar]

Proposed Changes

• added is_occupied field in Bed
• update is_occupied field when consultation bed is created (switch bed), patient consultation is created, and when the patient is discharged

Associated Issue

• Fixes Create is_occupied property in Bed model #1084

Architecture changes

• nil

@coronasafe/code-reviewers

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete

[codecov-commenter]

Codecov Report

Base: 55.98% // Head: 55.95% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8e7fbf5) compared to base (eb52c8a).
Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   55.98%   55.95%   -0.03%     
==========================================
  Files         175      175              
  Lines        8685     8689       +4     
  Branches     1468     1484      +16     
==========================================
  Hits         4862     4862              
- Misses       3771     3775       +4     
  Partials       52       52              

Impacted Files	Coverage Δ
care/facility/api/serializers/bed.py	41.02% <0.00%> (-0.72%)	⬇️
...e/facility/api/serializers/patient_consultation.py	32.96% <0.00%> (-0.19%)	⬇️
care/facility/api/viewsets/patient.py	47.91% <33.33%> (-0.34%)	⬇️
care/facility/models/bed.py	83.78% <100.00%> (+1.73%)	⬆️
care/users/api/viewsets/change_password.py	61.53% <0.00%> (+1.53%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[vigneshhari]

@rithviknishad @sainak review.

[rithviknishad]

This can be updated to simply check using bed.is_occupied instead now right?

[rithviknishad]

We could optimize the custom migration like this right?

Suggested change

	ConsultationBed = apps.get_model("facility", "ConsultationBed")
	for bed in Bed.objects.all():
	bed.is_occupied = ConsultationBed.objects.filter(
	bed=bed, end_date__isnull=True
	).exists()
	bed.save()
	Bed.objects.all().update(is_occupied=F("consultationbed__end_date__isnull"))

[rithviknishad]

or even:

Suggested change

	ConsultationBed = apps.get_model("facility", "ConsultationBed")
	for bed in Bed.objects.all():
	bed.is_occupied = ConsultationBed.objects.filter(
	bed=bed, end_date__isnull=True
	).exists()
	bed.save()
	Bed.objects.filter(consultationbed__end_date__isnull=True).update(is_occupied=True)

[sainak]

now that we have the value directly stored in the model we can directly get the object and check/update the status

[sainak]

Suggested change

	Bed = apps.get_model("facility", "Bed")
	ConsultationBed = apps.get_model("facility", "ConsultationBed")
	for bed in Bed.objects.all():
	bed.is_occupied = ConsultationBed.objects.filter(
	bed=bed, end_date__isnull=True
	).exists()
	bed.save()
	Bed = apps.get_model("facility", "Bed")
	ConsultationBed = apps.get_model("facility", "ConsultationBed")
	objs = []
	for consultation_bed in ConsultationBed.objects.filter(end_date__isnull=True).select_related("bed"):
	consultation_bed.bed.is_occupied=True
	objs.append(consultation_bed.bed)
	Bed.objects.bulk_update(objs, ['is_occupied'])