Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used facility.middleware_address for asset.meta.middleware_hostname in AssetIntgration #1127

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • used facility.middleware_address for asset.meta.middleware_hostname in AssetIntgration
  • made migrations (not related to this pr)

Associated Issue

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@codecov-commenter
Copy link

Codecov Report

Base: 55.66% // Head: 55.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c446a97) compared to base (4b47412).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1127   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files         177      177           
  Lines        8767     8768    +1     
  Branches     1504     1504           
=======================================
+ Hits         4880     4881    +1     
  Misses       3835     3835           
  Partials       52       52           
Impacted Files Coverage Δ
care/facility/api/viewsets/asset.py 55.11% <80.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nihal467 nihal467 added the P1 High priority; urgent label Dec 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit c368620 into master Dec 23, 2022
@sainak sainak deleted the fix#1126 branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use facility.middleware_address instead of asset.meta.middleware_hostname
4 participants