Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure compose config #1131

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Restructure compose config #1131

merged 4 commits into from
Dec 23, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 23, 2022 •
edited
Loading

Proposed Changes

  • Restructure the compose config such that common configuration is present in docker-compose.yaml
  • Updated Makefile such that prebuilt and local config overrides docker-compose.yaml

Raw outputs of config before this PR and of this PR:
https://gist.github.com/rithviknishad/fe661a0858642f2258451d6905dd78d6

diff of the docker-compose config of prebuilt.yaml and local.yaml:

(it's just a line position swap in both)

image

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@rithviknishad rithviknishad requested a review from a team as a code owner December 23, 2022 13:59
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit 335a307 into master Dec 23, 2022
@sainak sainak deleted the restructure-compose-config branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rithviknishad @vigneshhari