-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use configured middleware address for middleware authentication #1144
Use configured middleware address for middleware authentication #1144
Conversation
Codecov ReportBase: 55.68% // Head: 55.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
- Coverage 55.68% 55.63% -0.06%
==========================================
Files 177 177
Lines 8773 8783 +10
Branches 1505 1509 +4
==========================================
+ Hits 4885 4886 +1
- Misses 3836 3845 +9
Partials 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Are we no longer pointing to local if a middleware address is not present? |
7e11457
to
9f2881f
Compare
the url should start with http and should not end with /
9f2881f
to
12391cb
Compare
Kudos, SonarCloud Quality Gate passed!
|
This change would give more info to the admin about whats going wrong. |
Proposed Changes
Use configured middleware address for middleware authentication
@coronasafe/code-reviewers
Merge Checklist
/docs