Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configured middleware address for middleware authentication #1144

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented Jan 5, 2023

Proposed Changes

Use configured middleware address for middleware authentication

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@sainak sainak requested a review from a team as a code owner January 5, 2023 10:52
@codecov-commenter
Copy link

Codecov Report

Base: 55.68% // Head: 55.63% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (7e11457) compared to base (382346a).
Patch coverage: 9.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
- Coverage   55.68%   55.63%   -0.06%     
==========================================
  Files         177      177              
  Lines        8773     8783      +10     
  Branches     1505     1509       +4     
==========================================
+ Hits         4885     4886       +1     
- Misses       3836     3845       +9     
  Partials       52       52              
Impacted Files Coverage Δ
config/authentication.py 34.56% <0.00%> (-0.88%) ⬇️
care/facility/api/serializers/facility.py 75.71% <12.50%> (-8.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari
Copy link
Member

Are we no longer pointing to local if a middleware address is not present?

@sainak sainak force-pushed the sainak/feat/daily-round-middleware-address branch from 7e11457 to 9f2881f Compare January 12, 2023 10:34
@sainak sainak force-pushed the sainak/feat/daily-round-middleware-address branch from 9f2881f to 12391cb Compare January 12, 2023 10:38
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sainak
Copy link
Member Author

sainak commented Jan 12, 2023

Are we no longer pointing to local if a middleware address is not present?

This change would give more info to the admin about whats going wrong.
we were pointing it to local for testing, we can still set the value to localhost in the configurations

@vigneshhari vigneshhari merged commit 5e3aac2 into master Jan 12, 2023
@sainak sainak deleted the sainak/feat/daily-round-middleware-address branch June 2, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants