Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add new fields for patient discharge feature #1155

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

aeswibon
Copy link
Member

Feature Request

Proposed Changes

  • Add discharge date and prescription & PRN prescription fields for recovered patient
  • Add death datetime and death confirmed by fields for expired patient

Associated Issue

Architecture changes

  • N/A

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@aeswibon aeswibon requested a review from a team as a code owner January 13, 2023 03:13
@aeswibon aeswibon added the P1 High priority; urgent label Jan 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 55.63% // Head: 55.53% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (48f4d6d) compared to base (5e3aac2).
Patch coverage: 10.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   55.63%   55.53%   -0.11%     
==========================================
  Files         177      177              
  Lines        8782     8802      +20     
  Branches     1508     1513       +5     
==========================================
+ Hits         4886     4888       +2     
- Misses       3844     3862      +18     
  Partials       52       52              
Impacted Files Coverage Δ
care/facility/api/viewsets/patient.py 45.57% <0.00%> (-2.86%) ⬇️
care/facility/models/patient_consultation.py 95.52% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigneshhari
Copy link
Member

Can you create another issue to move the discharge view to use a serializer? it was a rather simple view, now that it's complicated, i recommend using a serializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new fields for patient discharge feature
3 participants