Restrict Admin from unlinking users from other district #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
+ Coverage 60.75% 60.91% +0.16%
==========================================
Files 210 210
Lines 11533 11535 +2
Branches 1644 1645 +1
==========================================
+ Hits 7007 7027 +20
+ Misses 4285 4259 -26
- Partials 241 249 +8 ☔ View full report in Codecov by Sentry. |
vigneshhari
requested changes
Jan 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
sainak
requested changes
Jun 24, 2023
Co-authored-by: Aakash Singh <mail@singhaakash.dev>
|
@Pranshu1902 add test cases |
|
@sainak @vigneshhari please review and merge the PR. I have added tests cases |
rithviknishad
approved these changes
Nov 3, 2023
|
@Pranshu1902 the test are not catching the changes, try to assert the error message response |
|
@sainak done |
sainak
reviewed
Nov 3, 2023
Co-authored-by: Aakash Singh <mail@singhaakash.dev>
sainak
approved these changes
Nov 3, 2023
vigneshhari
requested changes
Nov 8, 2023
sainak
approved these changes
Dec 6, 2023
rithviknishad
approved these changes
Dec 6, 2023
vigneshhari
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1152
Ensure that the admin's district is same as that of the facility user's district being deleted and also able to home facilities only for users within same district.