-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skills access for any user #1196
Conversation
Codecov ReportBase: 55.86% // Head: 56.02% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
+ Coverage 55.86% 56.02% +0.15%
==========================================
Files 177 174 -3
Lines 8832 8802 -30
Branches 1521 1519 -2
==========================================
- Hits 4934 4931 -3
+ Misses 3844 3817 -27
Partials 54 54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Kudos, SonarCloud Quality Gate passed!
|
): | ||
return False | ||
|
||
if not requesting_user.user_type >= user.user_type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no check that confirms if the user is part of the same dist as the dist admin or the same state as the state admin here, but i will approve this PR for now. Do make these changes later or start a new issue for it.
This should ideally be a helper function that checks if a user has control over another user. this might be useful in many other occasions.
This PR allows any user to access the skills of any other user.
Fixes coronasafe/care_fe#4830
Associated Issue
@coronasafe/code-reviewers